Skip to content

General - Add icons to ACE actions#1380

Merged
jonpas merged 10 commits intoIDI-Systems:masterfrom
Timi007:ace_action_icons
Dec 29, 2025
Merged

General - Add icons to ACE actions#1380
jonpas merged 10 commits intoIDI-Systems:masterfrom
Timi007:ace_action_icons

Conversation

@Timi007
Copy link
Copy Markdown
Contributor

@Timi007 Timi007 commented Feb 6, 2025

When merged this pull request will:

  • Add icons to ACE actions to radios
  • Add icons to intercom
  • Add icons to GSA
  • Cleanup code (use LLSTRING)

Example:
image

TODO

  • Add icons to self-interaction
  • Add icons to intercom
  • Add icons to shared radios
  • Add icons for intercom broadcast
  • Add icons for intercom accent

@Drofseh
Copy link
Copy Markdown
Contributor

Drofseh commented Feb 6, 2025

I'm not sure icons with letters should be used (L, R, PTT, etc) as they won't be translated if the user selects a non-English language,

@Timi007
Copy link
Copy Markdown
Contributor Author

Timi007 commented Feb 6, 2025

I'm not sure icons with letters should be used (L, R, PTT, etc) as they won't be translated if the user selects a non-English language,

I also am not sure how to depict those actions. I thought that L and R would be ok because most headphone makers also label it as such. In addition to that I added the sound direction. Would arrows be better or (double) chevrons? What about center, should it be left and right arrows?

Is a microphone with a number better suited for PTT?

@Drofseh
Copy link
Copy Markdown
Contributor

Drofseh commented Feb 6, 2025

I'm not sure icons with letters should be used (L, R, PTT, etc) as they won't be translated if the user selects a non-English language,

I also am not sure how to depict those actions. I thought that L and R would be ok because most headphone makers also label it as such. In addition to that I added the sound direction. Would arrows be better or (double) chevrons? What about center, should it be left and right arrows?

Is a microphone with a number better suited for PTT?

I think probably just the sound wave icons, (((, ))), ((( ))), are fine for L, R, and C
You could do waves and an arrow ((( <- but I'm not sure if it'd be better or not.

Mic icon by itself (no number) is probably fine for the PTT icons. The number is presumably always in the text right under the icon.

@Timi007 Timi007 marked this pull request as ready for review February 9, 2025 21:05
@Timi007
Copy link
Copy Markdown
Contributor Author

Timi007 commented Feb 9, 2025

I think this is ready for review.

@jonpas jonpas added this to the 2.14.0 milestone Feb 10, 2025
@jonpas
Copy link
Copy Markdown
Member

jonpas commented Dec 14, 2025

Are we happy with these wave icons? I personally have no clue which is Left and Right from the icon itself, but I also don't think it really matters.

If we want them clearer, maybe some ear on the side or something?

Copy link
Copy Markdown
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to change icons in the future, we can, I am merging this as it is an improvement for sure.

@jonpas jonpas merged commit 16cb2e8 into IDI-Systems:master Dec 29, 2025
3 checks passed
@Timi007 Timi007 deleted the ace_action_icons branch January 4, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants